Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics #34

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Update metrics #34

merged 1 commit into from
Dec 6, 2018

Conversation

matthsmi
Copy link
Collaborator

@matthsmi matthsmi commented Dec 6, 2018

Renamed stats to metrics.

Also moved all metrics instantiation into init().

@codecov-io
Copy link

codecov-io commented Dec 6, 2018

Codecov Report

Merging #34 into master will increase coverage by 2.6%.
The diff coverage is 55.18%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #34     +/-   ##
=========================================
+ Coverage   29.18%   31.79%   +2.6%     
=========================================
  Files          17       17             
  Lines        2169     2120     -49     
=========================================
+ Hits          633      674     +41     
+ Misses       1492     1402     -90     
  Partials       44       44
Impacted Files Coverage Δ
internal/config/chan.go 0% <0%> (ø) ⬆️
internal/methods/http.go 23.3% <0%> (ø) ⬆️
internal/config/helpers.go 42.94% <0%> (ø) ⬆️
internal/config/manager.go 0% <0%> (ø) ⬆️
internal/config/handler.go 16.2% <12.5%> (ø) ⬆️
internal/metrics/metrics.go 70.55% <70.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95711e8...bb4494f. Read the comment docs.

@matthsmi matthsmi merged commit fa4c10c into adobe:master Dec 6, 2018
@matthsmi matthsmi deleted the metrics branch December 19, 2018 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants