Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidying up how we're handling the different methods #35

Merged
merged 7 commits into from
Dec 19, 2018

Conversation

mslocrian
Copy link
Contributor

There was a lot of repetitive checks happening when differentiating between butler retrieval methods.

Tried to tidy a lot of that up.

I also tweaked how we do the blob storage. Instead of specifying some BUTLER_ specific environment variables and shoving them across to the right azure blob storage vars, I removed that, since it's silly. Just specify what azure expects.

@codecov-io
Copy link

Codecov Report

Merging #35 into master will increase coverage by 0.22%.
The diff coverage is 36.99%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   31.79%   32.02%   +0.22%     
==========================================
  Files          17       17              
  Lines        2120     2133      +13     
==========================================
+ Hits          674      683       +9     
- Misses       1402     1404       +2     
- Partials       44       46       +2
Impacted Files Coverage Δ
internal/config/manager.go 0% <0%> (ø) ⬆️
cmd/butler/main.go 10.55% <0%> (-1.42%) ⬇️
internal/methods/methods.go 20% <0%> (-1.06%) ⬇️
internal/monitor/monitor.go 83.07% <100%> (ø) ⬆️
internal/config/config.go 18.84% <11.11%> (-1.47%) ⬇️
internal/config/objects.go 4.25% <16.66%> (+4.25%) ⬆️
internal/config/helpers.go 42.56% <49.12%> (-0.38%) ⬇️
internal/methods/blob.go 78.46% <61.11%> (-9.04%) ⬇️
internal/config/handler.go 19.15% <64.51%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa4c10c...69cc67b. Read the comment docs.

@matthsmi matthsmi merged commit fe50d2a into adobe:master Dec 19, 2018
@matthsmi matthsmi deleted the improvements branch December 19, 2018 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants