Skip to content
This repository has been archived by the owner on Sep 11, 2020. It is now read-only.

CIF-684 - Upgrade CI environment to Node 10 LTS #20

Merged
merged 4 commits into from
Jan 2, 2019
Merged

Conversation

herzog31
Copy link
Member

@herzog31 herzog31 commented Jan 2, 2019

Motivation and Context

I/O Runtime is phasing out nodejs:6 containers and recommends the usage of nodejs:10 containers with the Node 10 LTS version. This change updates the CI container, so that tests are performed in the same environment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code passes the code style as defined by ESLint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov-io
Copy link

codecov-io commented Jan 2, 2019

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files          17       17           
  Lines         455      455           
=======================================
  Hits          416      416           
  Misses         39       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14daf64...db71072. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants