Skip to content

Commit

Permalink
fix: Coral shell help items should have list role (#321)
Browse files Browse the repository at this point in the history
Co-authored-by: TeodorS <teodors@ensemble.com>
  • Loading branch information
ens84646 and TeodorEns committed Nov 22, 2023
1 parent 4b86af1 commit 5c631fd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions coral-component-shell/src/scripts/ShellHelpItem.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ class ShellHelpItem extends AnchorList.Item {
super.render();

this.classList.add(CLASSNAME);
this.setAttribute("role", "listitem");
}
}

Expand Down
2 changes: 1 addition & 1 deletion coral-component-shell/src/templates/help.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<div handle="contentWrapper">
<label class="u-coral-screenReaderOnly" id="{{labelId}}">{{data.i18n.get('Search for Help')}}</label>
<coral-search class="_coral-Shell-help-search" handle="search" placeholder="{{data.i18n.get('Search for Help')}}" labelledby="{{labelId}}"></coral-search>
<div class="_coral-Shell-help-items" handle="items"></div>
<div class="_coral-Shell-help-items" handle="items" role="list"></div>
<coral-anchorlist class="_coral-Shell-help-results" handle="results" hidden></coral-anchorlist>
<div class="_coral-Shell-help-resultMessage" handle="resultMessage" role="status" hidden></div>
<div class="_coral-Shell-help-loading" handle="loading" role="status" hidden>
Expand Down

0 comments on commit 5c631fd

Please sign in to comment.