-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Accessability): Add button role to table header interactive element #347
Conversation
Hi @StoianLucian , The coral-table-headercell-content should be role button, I guess that would correct the accessibility. Since the impact of this change is quite large spread, please add a null check to avoid same regression in future. Thank you |
There seem to be some strange choices going on when the table header is @StoianLucian and @Pareesh, do you mind if I commit some suggested changes to this PR? |
hello @majornista, Please do! |
- Column header cells should always have role="columnheader". - Sortable cell content should have role="button" and tabindex="0". - Sortable column header cells should have aria-sort attribute, regardless of whether or not the table header row is sticky.
Hi @majornista @StoianLucian , Thank you |
Hi @Pareesh the changes are done |
## [4.16.2](v4.16.1...v4.16.2) (2024-05-15) ### Bug Fixes * **Accessability:** Add button role to table header interactive element ([#347](#347)) ([a17ed32](a17ed32))
🎉 This PR is included in version 4.16.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Ticket: SITES-10962
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: