Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Parcel for building and adjust export path and build #108

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

holblin
Copy link

@holblin holblin commented Mar 7, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jogibear9988
Copy link

do you still add file extensions to imports in the esm build?

@holblin
Copy link
Author

holblin commented Mar 7, 2023

Hi @jogibear9988 , I do not understand your question. Could you rephrase it and give me an example with the current result and the expected result if there is a concern or a problem?

@holblin
Copy link
Author

holblin commented Mar 8, 2023

@jogibear9988 , I will address potential feedback on the next beta / rc version

@jogibear9988
Copy link

For me this now does not work, cause I want to use it in a VSCode extension, wich does not allow .mjs at the moment.
But I created an issue for this a vscode:
microsoft/vscode#176567

@jogibear9988
Copy link

But I think the mime type for .mjs/.cjs could more often be a problem. I think to move it to two folders with .js extension would be more error prune

@holblin
Copy link
Author

holblin commented Mar 9, 2023

Would that be a problem for you to use version 4.2.x until microsoft/vscode#176576 is merged?
I could also, do the two folder things if the vscode PR doesn't get some traction (but that would be better if they fix it on their side).

@jogibear9988
Copy link

for me it's now not a problem any more, but I wanted to show that it could be a problem for more people, cause mime type support dor these extensions is often not so good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants