Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Playwright tests #168

Merged
merged 6 commits into from
May 30, 2024
Merged

Improve Playwright tests #168

merged 6 commits into from
May 30, 2024

Conversation

bosschaert
Copy link
Contributor

@bosschaert bosschaert commented May 28, 2024 •
edited
Loading

Playwright test changes:

  • Added new test that navigates between pages by changing the URL and edits them. One of the pages has a sheet the other has text (covers 3 of the 4 items on https://github.com/adobe/da-live/wiki/TODO-%E2%80%90-Playwright-tests )
  • Support for running the tests against a locally running da-collab and da-admin (triggered by setting the env var GITHUB_HEAD_REF=local which now also selects these locally via query param)
  • Updated the regionaledit test to run in its own unique directory to allow multi browser tests to run concurrently without tripping over each other

How Has This Been Tested?

These are tests...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented May 28, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@bosschaert bosschaert requested a review from karlpauls May 29, 2024 08:45
@bosschaert
Run the regionaledits test in a unique test folder
224e6b1 
This to support multiple tests running in parallel without tripping over
each other. Playwright in some cases runs tests in parallel (e.g.
different browsers)

The deletion of the unique test folders is handled automatically by the
delete.spec.js
@bosschaert bosschaert changed the title Fix Playwright tests Improve Playwright tests May 30, 2024
@bosschaert bosschaert merged commit da40850 into main May 30, 2024
5 of 6 checks passed
@bosschaert bosschaert deleted the fix-pw branch May 30, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischrischris chrischrischris chrischrischris approved these changes

@auniverseaway auniverseaway Awaiting requested review from auniverseaway

@karlpauls karlpauls Awaiting requested review from karlpauls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bosschaert @chrischrischris