Add video block for embedded videos #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zastrow
force-pushed
the
sbx-video-embeds
branch
from
25e7f1c
to
67c35c8
Compare
|
zastrow
force-pushed
the
sbx-video-embeds
branch
from
67c35c8
to
c07ae68
Compare
|
jeramygabby
approved these changes
Jun 26, 2022
kaseybon
approved these changes
Jul 11, 2022
|
|
||
| /* If the browser supports the aspect-ratio property | ||
| then use it and remove the padding-based ratio */ | ||
| @supports (aspect-ratio: 16/9) { |
zastrow
force-pushed
the
sbx-video-embeds
branch
from
c07ae68
to
62c407b
Compare
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This creates a new block for content to display video embeds like those from YouTube or Vimeo. The block is called video and expects the first table cell to contain an embed code and optionally another row cell can contain a caption.
This addresses Issue #43
Motivation and Context
The will allow content creators to add video to stories
How Has This Been Tested?
Tested with a new page to demo the feature: https://sbx-video-embeds--design-website--adobe.hlx.page/drafts/demo-draft
Screenshots (if appropriate):
Types of changes
Checklist: