Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY]#186 add initial action generator for AEMHeadlessClient SDK #185

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

easingthemes
Copy link
Contributor

@easingthemes easingthemes commented Feb 25, 2022

Description

Added action generator for AEM Headless Client

Related Issue

adobe/aem-headless-client-nodejs#2
#186

Motivation and Context

How Has This Been Tested?

Unit tests
Tested with demo project for aio action using remote AEMaaCS with basic auth

Screenshots (if appropriate):

Screenshot 2022-03-06 at 01 23 20

Types of changes

Added action generator for AEM Headless Client adobe/aem-headless-client-nodejs#2

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@easingthemes easingthemes changed the title [WIP]#2 add initial action generator [WIP]#2 add initial action generator for AEMHeadlessClient SDK Feb 25, 2022
@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #185 (2cf9e20) into master (01426a3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #185   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        27    +1     
  Lines          645       656   +11     
  Branches        71        71           
=========================================
+ Hits           645       656   +11     
Impacted Files Coverage Δ
generators/add-action/index.js 100.00% <ø> (ø)
lib/constants.js 100.00% <ø> (ø)
generators/add-action/aem-headless-client/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01426a3...2cf9e20. Read the comment docs.

@easingthemes easingthemes changed the title [WIP]#2 add initial action generator for AEMHeadlessClient SDK [READY]#186 add initial action generator for AEMHeadlessClient SDK Mar 6, 2022
@easingthemes easingthemes marked this pull request as ready for review March 6, 2022 00:27
@shazron
Copy link
Member

shazron commented Mar 7, 2022

Hi Dragan,
We are in the middle of doing extraction of some of the generators as templates, starting with extensions. This is to facilitate dynamic usage of templates/generators:

  1. https://github.com/adobe/generator-app-excshell
  2. https://github.com/adobe/generator-app-asset-compute

They currently reside here: https://github.com/adobe/generator-aio-app/tree/master/generators/extensions

First step we are taking on are extensions (and their add-action generators), and the generator-aio-app repo will add the templates as dependencies for backwards compatibility. In the future, they will be pulled directly from their template source, and not from generator-aio-app.

Any future generators, including action generators, should be in a separate module because of this. You can use https://github.com/adobe/generator-app-common-lib to use the ActionGenerator base class.

@easingthemes
Copy link
Contributor Author

Thanks, I'll check.
It makes sense, already started to be crowded for one module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants