Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy in staging should not trigger the publish process #232

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

fe-lix-
Copy link
Contributor

@fe-lix- fe-lix- commented Sep 25, 2023

Deploy to Stage should not trigger the publish process

Description

GitHub action should make sure user by default do not publish in the stage workspace. If not this will result with the following error:

- Getting Extension Points in Workspace=***...
>    Error: [CoreConsoleAPISDK:ERROR_GET_WORKSPACE_ENDPOINTS] 500 - Internal

Motivation and Context

This was reported by a customer.

How Has This Been Tested?

  • Deploy actions now works on GitHub.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #232 (eb21b83) into master (190b65c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #232   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          313       313           
  Branches        44        44           
=========================================
  Hits           313       313           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron shazron merged commit 729fae5 into adobe:master Sep 25, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants