Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pin eslint-plugin-n to ^15.7 to support node 14 #32

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix: pin eslint-plugin-n to ^15.7 to support node 14 #32

merged 1 commit into from
Sep 13, 2023

Conversation

MichaelGoberling
Copy link
Contributor

Description

Version ^16.0 of eslint-plugin-n doesn't support Node 14, but aio still does. Pin to ^15.7 for now

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron merged commit 67720f7 into main Sep 13, 2023
5 checks passed
@shazron shazron deleted the pin-eslint-plugin-n branch September 13, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shazron shazron shazron approved these changes

@moritzraho moritzraho Awaiting requested review from moritzraho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MichaelGoberling @shazron