Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update hooks for aio-cli-plugin-asset-compute@v4 #5

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

shazron
Copy link
Member

@shazron shazron commented Oct 11, 2022

Description

The plugin version at v4, uses oclif@v2, which had this quirk we relied upon, where we didn't need to specify the command topic beforehand.

Depends on:

  1. fix: update aio-cli-plugin-asset-compute v4.0.2 generator-add-action-asset-compute#3
  2. app:deploy --skip-deploy has been removed aio-cli-plugin-asset-compute#95

How Has This Been Tested?

Pending.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

shazron and others added 2 commits October 12, 2022 00:15
The plugin version at v4, uses oclif@v2, which had this quirk we relied upon, where we didn't need to specify the command topic beforehand.
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #5 (5c7208c) into main (e2cea3c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           23        23           
=========================================
  Hits            23        23           
Impacted Files Coverage Δ
index.js 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron shazron added the bug Something isn't working label Oct 27, 2022
@shazron shazron marked this pull request as ready for review October 27, 2022 16:26
@MichaelGoberling
Copy link
Contributor

@shazron Are you familiar with the adobe-asset-compute executable referenced in the generator? Should this be aio?

Copy link

@jdelbick jdelbick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be merged now that this one is released: adobe/aio-cli-plugin-asset-compute#95

@shazron shazron merged commit d73ad0f into main Nov 9, 2022
@shazron shazron deleted the add-topic-to-command branch November 9, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants