Skip to content
This repository has been archived by the owner on Jul 12, 2021. It is now read-only.

feat: generate helix-config.json #35

Merged
merged 2 commits into from
Jun 8, 2021
Merged

feat: generate helix-config.json #35

merged 2 commits into from
Jun 8, 2021

Conversation

tripodsan
Copy link
Contributor

fixes #7

@github-actions
Copy link

github-actions bot commented Jun 7, 2021

This PR will trigger a minor release when merged.

trieloff
trieloff approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@trieloff trieloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected this to simply call helix-config-aggregator, but this works, too.

@trieloff
Copy link
Contributor

trieloff commented Jun 7, 2021

@tripodsan note that helix-config-aggregator still has an open issue to include metadata.json: adobe/helix-config-aggregator#10

@trieloff trieloff mentioned this pull request Jun 7, 2021
Open
@tripodsan
Copy link
Contributor Author

I would have expected this to simply call helix-config-aggregator, but this works, too.

yes..but... 2 reasons:

  1. it anyways needs to read the modified config
  2. we don't need to send the token along
  3. we reduce the amount of services

@tripodsan
Copy link
Contributor Author

@tripodsan note that helix-config-aggregator still has an open issue to include metadata.json: adobe/helix-config-aggregator#10

thanks. I only wanted to include the reference to the metadata.json if it exists, and not the entire metadata, because it changes quite often. I'll create an issue.

@tripodsan tripodsan merged commit 2d1d7b8 into main Jun 8, 2021
@tripodsan tripodsan deleted the implement-config-aggregate branch June 8, 2021 03:19
trieloff pushed a commit that referenced this pull request Jun 8, 2021
@semantic-release-bot
chore(release): 1.2.0 [skip ci]
cfdcf2d 
# [1.2.0](v1.1.9...v1.2.0) (2021-06-08)

### Features

* generate helix-config.json ([#35](#35)) ([2d1d7b8](2d1d7b8)), closes [#7](#7)
@trieloff
Copy link
Contributor

trieloff commented Jun 8, 2021

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trieloff trieloff trieloff approved these changes

@dominique-pfister dominique-pfister Awaiting requested review from dominique-pfister

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create helix-config when respective files are modified
2 participants
@tripodsan @trieloff