Implement it #2
Implement it #2
Conversation
trieloff
commented
Apr 30, 2021
trieloff
commented
- feat: first implementation
- test(post-deploy): add post-deploy test
- build(test): exit mocha
- build(test): do not require full branch coverage
- test: format fixture
|
This PR will trigger a minor release when merged. |
Codecov Report
@@ Coverage Diff @@
## main #2 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 8 11 +3
=========================================
+ Hits 8 11 +3
Continue to review full report at Codecov.
|
src/index.js
Outdated
| } | ||
|
|
||
| module.exports.main = wrap(main) | ||
| .with(status) | ||
| .with(logger.trace) | ||
| .with(logger); | ||
| .with(logger) | ||
| .with(optionalConfig, 'redirect', 'fstab', 'markup', 'index'); |
There was a problem hiding this comment.
do we really need markup ?
There was a problem hiding this comment.
LGTM (except the reduce :-) ).
but can we also include the
head.html?helix-version.txt?
@davidnuescheler ideally, we could also consider the existence of a metadata.json as config. i.e. just add a:
"metadata": "/metadata.json`
entry. so we don't need to fetch a 404 if there is none.
| } | ||
|
|
||
| module.exports.main = wrap(main) | ||
| .with(status) | ||
| .with(optionalConfig, 'redirect', 'fstab', 'markup', 'index') |
There was a problem hiding this comment.
@trieloff I moved this up, so that logging is enabled
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
