-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
Co-Authored-By: Tobias Bocanegra <tripodsan@users.noreply.github.com>
Co-Authored-By: Tobias Bocanegra <tripodsan@users.noreply.github.com>
Co-Authored-By: Tobias Bocanegra <tripodsan@users.noreply.github.com>
This PR will trigger a minor release when merged. |
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 4 +1
Lines 40 67 +27
=====================================
+ Hits 40 67 +27
Continue to review full report at Codecov.
|
This PR will trigger a minor release when merged. |
This PR will trigger a minor release when merged. |
This PR will trigger a minor release when merged. |
This PR will trigger a minor release when merged. |
This PR will trigger a minor release when merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- some minor details
- I still think we should not use the
__ow_path
, but let's tackle this is a different issue. escape or don't use__ow_path
to pass external resource url #11
|
||
|
||
module.exports = { | ||
required: ['share', 'AZURE_WORD2MD_CLIENT_ID', 'AZURE_HELIX_USER', 'AZURE_HELIX_PASSWORD'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would allow both, user/pass and refresh token.
This PR will trigger a minor release when merged. |
Co-Authored-By: Tobias Bocanegra <tripodsan@users.noreply.github.com>
This PR will trigger a minor release when merged. |
Co-Authored-By: Tobias Bocanegra <tripodsan@users.noreply.github.com>
This PR will trigger a minor release when merged. |
🎉 This PR is included in version 1.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This is an alternative to #6 but using the Excel API. There are no offline tests yet because this would require mocking eight requests.