Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

Excel Support (Using Graph API) #10

Merged
merged 24 commits into from
Mar 27, 2020
Merged

Excel Support (Using Graph API) #10

merged 24 commits into from
Mar 27, 2020

Conversation

trieloff
Copy link
Contributor

This is an alternative to #6 but using the Excel API. There are no offline tests yet because this would require mocking eight requests.

@github-actions
Copy link

This PR will trigger a minor release when merged.

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #10   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      4    +1     
  Lines          40     67   +27     
=====================================
+ Hits           40     67   +27
Impacted Files Coverage Δ
src/matchers/excel.js 100% <100%> (ø)
src/embed.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec2715...7a458ab. Read the comment docs.

@github-actions
Copy link

This PR will trigger a minor release when merged.

@github-actions
Copy link

This PR will trigger a minor release when merged.

@github-actions
Copy link

This PR will trigger a minor release when merged.

@github-actions
Copy link

This PR will trigger a minor release when merged.

@github-actions
Copy link

This PR will trigger a minor release when merged.

Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/matchers/excel.js Outdated Show resolved Hide resolved


module.exports = {
required: ['share', 'AZURE_WORD2MD_CLIENT_ID', 'AZURE_HELIX_USER', 'AZURE_HELIX_PASSWORD'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would allow both, user/pass and refresh token.

src/matchers/excel.js Outdated Show resolved Hide resolved
src/matchers/excel.js Outdated Show resolved Hide resolved
@github-actions
Copy link

This PR will trigger a minor release when merged.

Co-Authored-By: Tobias Bocanegra <tripodsan@users.noreply.github.com>
@github-actions
Copy link

This PR will trigger a minor release when merged.

Co-Authored-By: Tobias Bocanegra <tripodsan@users.noreply.github.com>
@github-actions
Copy link

This PR will trigger a minor release when merged.

@trieloff trieloff merged commit 3749406 into master Mar 27, 2020
@trieloff
Copy link
Contributor Author

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants