This repository has been archived by the owner on Feb 25, 2022. It is now read-only.
feat(excel): avoid caching in runtime #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a minor release when merged. |
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 293 293
=========================================
Hits 293 293
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
trieloff
reviewed
Jul 17, 2020
| @@ -46,7 +46,7 @@ async function extract(url, params, log = console) { | |||
| statusCode: 200, | |||
| headers: { | |||
| 'Content-Type': 'application/json', | |||
| 'Cache-Control': 'max-age=600', | |||
| 'cache-control': 'no-store, private, must-revalidate', | |||
There was a problem hiding this comment.
This seems overly aggressive.
There was a problem hiding this comment.
discussed with @davidnuescheler that we should only cache in fastly. as it is invoked by the content-proxy, which is requested by fastly, this is the most transparent way to handle it.
trieloff
added a commit
to adobe/helix-content-proxy
that referenced
this pull request
Aug 20, 2020
Adobe I/O Runtime respects the `no-cache` directive in the `Cache-Control` *request* header, which will allow us to do a partial revert of adobe/helix-data-embed#131 and keep some caching as the default see adobe/helix-data-embed#153
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #90