feat: implement superscript and subscript support (#137)

adobe · Apr 20, 2023 · 1f0d97f · 1f0d97f
1 parent 3d514d6
commit 1f0d97f
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 16 deletions.
diff --git a/src/importer/PageImporter.js b/src/importer/PageImporter.js
@@ -33,6 +33,21 @@ function remarkImageReferences() {
   return imageReferences;
 }
 
+function htmlElementNode(element, state, node) {
+  if (node.children && node.children.length > 0) {
+    return [{
+      type: 'html',
+      value: `<${element}>`,
+    },
+    ...state.all(node),
+    {
+      type: 'html',
+      value: `</${element}>`,
+    }];
+  }
+  return '';
+}
+
 export default class PageImporter {
   params;
 
@@ -65,20 +80,9 @@ export default class PageImporter {
       .use(parse, { emitParseErrors: true })
       .use(rehype2remark, {
         handlers: {
-          u: (state, node) => {
-            if (node.children && node.children.length > 0) {
-              return [{
-                type: 'html',
-                value: '<u>',
-              },
-              ...state.all(node),
-              {
-                type: 'html',
-                value: '</u>',
-              }];
-            }
-            return '';
-          },
+          u: (state, node) => htmlElementNode('u', state, node),
+          sub: (state, node) => htmlElementNode('sub', state, node),
+          sup: (state, node) => htmlElementNode('sup', state, node),
           ...gridtableHandlers,
         },
       })

diff --git a/test/importers/PageImporter.spec.js b/test/importers/PageImporter.spec.js
@@ -178,7 +178,7 @@ describe('PageImporter tests - fixtures', () => {
     await featureTest('space');
   });
 
-  it('import - strikethroughs', async () => {
-    await featureTest('s');
+  it('import - sub and sup', async () => {
+    await featureTest('subsup');
   });
 });
diff --git a/test/importers/fixtures/subsup.spec.html b/test/importers/fixtures/subsup.spec.html
@@ -0,0 +1,7 @@
+<html>
+  <body>
+    <h1>sub and sup</h1>
+    <p>This text must be a <sub>subscript</sub>.</p>
+    <p>This text must be a <sup>superscript</sup>.</p>
+  </body>
+</html>
diff --git a/test/importers/fixtures/subsup.spec.md b/test/importers/fixtures/subsup.spec.md
@@ -0,0 +1,5 @@
+# sub and sup
+
+This text must be a <sub>subscript</sub>.
+
+This text must be a <sup>superscript</sup>.