fix: support <s> tag (#76)

adobe · Jan 23, 2023 · 2691506 · 2691506
1 parent 35d27cf
commit 2691506
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -57,6 +57,7 @@
     "node-fetch": "3.3.0",
     "rehype-parse": "8.0.4",
     "rehype-remark": "github:adobe-rnd/rehype-remark#45735e80a3d3c805d3c4211ae035f718ddd10bcb",
+    "remark-gfm": "3.0.1",
     "remark-stringify": "10.0.2",
     "unified": "10.1.2"
   }

diff --git a/src/importer/PageImporter.js b/src/importer/PageImporter.js
@@ -22,7 +22,7 @@ import stringify from 'remark-stringify';
 import fs from 'fs-extra';
 import { md2docx } from '@adobe/helix-md2docx';
 import remarkGridTable from '@adobe/remark-gridtables';
-import { imageReferences } from '@adobe/helix-markdown-support';
+import { imageReferences, remarkGfmNoLink } from '@adobe/helix-markdown-support';
 import gridtableHandlers from './hast-to-mdast-gridtable-handlers.js';
 import Utils from '../utils/Utils.js';
 import DOMUtils from '../utils/DOMUtils.js';
@@ -84,6 +84,7 @@ export default class PageImporter {
       })
       .use(remarkImageReferences)
       .use(remarkGridTable)
+      .use(remarkGfmNoLink)
       .use(stringify, {
         bullet: '-',
         fence: '`',

diff --git a/test/importers/PageImporter.spec.js b/test/importers/PageImporter.spec.js
@@ -177,4 +177,8 @@ describe('PageImporter tests - fixtures', () => {
   it('import - spaces', async () => {
     await featureTest('space');
   });
+
+  it('import - strikethroughs', async () => {
+    await featureTest('s');
+  });
 });
diff --git a/test/importers/fixtures/s.spec.html b/test/importers/fixtures/s.spec.html
@@ -0,0 +1,14 @@
+<html>
+  <body>
+    <h1>strikethrough sample</h1>
+    <p><s>strikethrough 1</s></p>
+    <p>removed <del>strikethrough 2</del> but added <ins>insert 3</ins></p>
+    <p></p>
+    <p>
+      <b>
+        <s><span>US$84.99/mo</span></s>
+        <span>US$59.99/mo</span>&nbsp;per license
+      </b>
+    </p>
+  </body>
+</html>
diff --git a/test/importers/fixtures/s.spec.md b/test/importers/fixtures/s.spec.md
@@ -0,0 +1,7 @@
+# strikethrough sample
+
+~~strikethrough 1~~
+
+removed ~~strikethrough 2~~ but added insert 3
+
+**~~US$84.99/mo~~ US$59.99/mo per license**