Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bold text without spaces leads to ** in document #214

Closed
synox opened this issue Aug 24, 2023 · 3 comments · Fixed by #223
Closed

Bold text without spaces leads to ** in document #214

synox opened this issue Aug 24, 2023 · 3 comments · Fixed by #223
Labels
bug Something isn't working released

Comments

@synox
Copy link
Collaborator

synox commented Aug 24, 2023

Description
when importing https://www.24life.com/traveling-transformation/

there is the HTML

<p><strong>THE STAY:</strong>Kulm Hotel St. Moritz &amp; Grand Hotel Kronenhof<br>

which causes markdown to produce:

**THE STAY:**Kulm Hotel St. Moritz & Grand Hotel Kronenhof

which turns into the word document:
Screenshot 2023-08-23 at 17 21 50

To Reproduce
Run import on that url.

Expected behavior
Importer should handle bold text properly.
@synox synox added the bug Something isn't working label Aug 24, 2023
@tripodsan tripodsan mentioned this issue Aug 24, 2023
Merged
1 task
@tripodsan
Copy link
Contributor

should be fixed with #215

@synox
Copy link
Collaborator Author

synox commented Aug 24, 2023

@tripodsan still happens with 14.24.12

@tripodsan tripodsan reopened this Aug 26, 2023
tripodsan added a commit that referenced this issue Sep 7, 2023
@tripodsan
fix: cleanup mdast tree before writing as md
d2df6dd 
fixes #217

fixes #214

fixes #166

fixes #213
@tripodsan tripodsan mentioned this issue Sep 7, 2023
Merged
tripodsan added a commit that referenced this issue Sep 7, 2023
@tripodsan
fix: cleanup mdast tree before writing as md (#223)
49f88ce 
fixes #217

fixes #214

fixes #166

fixes #213
github-actions bot pushed a commit that referenced this issue Sep 7, 2023
@semantic-release-bot
chore(release): 2.9.29 [skip ci]
4b5adf3 
## [2.9.29](v2.9.28...v2.9.29) (2023-09-07)

### Bug Fixes

* cleanup mdast tree before writing as md ([#223](#223)) ([49f88ce](49f88ce)), closes [#217](#217) [#214](#214) [#166](#166) [#213](#213)
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

🎉 This issue has been resolved in version 2.9.29 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: cleanup mdast tree before writing as md adobe/helix-importer
2 participants
@tripodsan @synox