Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for special onedrive uris #68

Closed
tripodsan opened this issue Jul 16, 2020 · 1 comment · Fixed by #70
Closed

Add support for special onedrive uris #68

tripodsan opened this issue Jul 16, 2020 · 1 comment · Fixed by #70
Assignees
@tripodsan
Labels
enhancement New feature or request released

Comments

@tripodsan
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
in order to transport driveId/itemId references, it would be convenient to have a transparent, detectable serialization for it.
internally, the code uses /drives/<driveId>/items/<itemId> a lot, so it might make sense to use something similar

Describe the solution you'd like

  • suggestion to use a special URI scheme: onedrive with the aforementioned path to the item. eg:
onedrive:/drives/b!2nFK7YhvL0yLgH3l_6DPvdBErfBlFFRPphB3wsFazXGX6gDR8muPTo89wY6LZLgv/items/01YELWHJW476LYB5AGBBEYZOIIP4TEEB53
  • there should be methods to transform a driveItem object to and from such an URI
  • resolve sharelink should also be able to handle a onedrive uri.

Additional context
this could also be used in mountpoints. see https://github.com/adobe/helix-word2md/issues/70
@tripodsan tripodsan added the enhancement New feature or request label Jul 16, 2020
@tripodsan tripodsan mentioned this issue Jul 16, 2020
Merged
@tripodsan tripodsan self-assigned this Jul 16, 2020
@tripodsan tripodsan mentioned this issue Jul 16, 2020
Merged
tripodsan added a commit that referenced this issue Jul 17, 2020
@tripodsan
feat(onedrive): add support for onedrive uri
8ec07ec 
fixes #68, fixes #69
trieloff pushed a commit that referenced this issue Jul 17, 2020
@semantic-release-bot
chore(release): 2.8.0 [skip ci]
3253f53 
# [2.8.0](v2.7.0...v2.8.0) (2020-07-17)

### Features

* **onedrive:** add support for onedrive uri ([8ec07ec](8ec07ec)), closes [#68](#68) [#69](#69)
@trieloff
Copy link

🎉 This issue has been resolved in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jul 17, 2020
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tripodsan tripodsan

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(onedrive): add support for onedrive uri adobe/helix-onedrive-support
2 participants
@trieloff @tripodsan