Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring Setup fails #10

Closed
rofe opened this issue Nov 28, 2019 · 3 comments · Fixed by #11
Closed

Monitoring Setup fails #10

rofe opened this issue Nov 28, 2019 · 3 comments · Fixed by #11
Assignees
Labels
bug Something isn't working released

Comments

@rofe
Copy link
Collaborator

rofe commented Nov 28, 2019

Description
Latest changes to the shell script fail to properly pass strings containing spaces.

To Reproduce

  1. Error in CircleCI ('Monitoring Setup step insemantic-release` job):
spName="Foo Bar Test"
(...)
# statuspage automation
spEmail=`node ${toolPath}/statuspage setup --silent ${spName:+--name \"${spName}\"} ${spGroup:+--group \"${spGroup}\"}`
(...)
statuspage setup

Create or reuse a Statuspage component

Options:
  --version            Show version number                             [boolean]
  --help               Show help                                       [boolean]
  --auth               Statuspage API Key (or env $STATUSPAGE_AUTH)
                                                             [string] [required]
  --page_id, --pageId  Statuspage Page ID (or env $STATUSPAGE_PAGE_ID)
                                                             [string] [required]
  --name               The name of the component
                                      [string] [default: "@adobe/helix-word2md"]
  --description        The description of the component
     [string] [default: "Helix Service that renders word documents as markdown"]
  --group              The name of an existing component group          [string]
  --silent             Reduce output to automation email only
                                                      [boolean] [default: false]

Unknown arguments: Foo, Test"
Exited with code 1

Expected behavior
Monitoring Setup correctly uses the name from the parameter

Version:
Orb adobe/helix-post-deploy@1.2.2

@rofe rofe added the bug Something isn't working label Nov 28, 2019
@rofe rofe self-assigned this Nov 28, 2019
@rofe rofe closed this as completed in #11 Nov 28, 2019
rofe added a commit that referenced this issue Nov 28, 2019
fix(monitoring): monitoring setup fails (#10)
adobe-bot pushed a commit that referenced this issue Nov 28, 2019
## [1.1.1](v1.1.0...v1.1.1) (2019-11-28)

### Bug Fixes

* **monitoring:** monitoring setup fails ([#10](#10)) ([8379160](8379160))
@adobe-bot
Copy link

🎉 This issue has been resolved in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rofe rofe reopened this Nov 28, 2019
@rofe
Copy link
Collaborator Author

rofe commented Nov 28, 2019

Waiting for proof it's actually working...

@rofe
Copy link
Collaborator Author

rofe commented Nov 28, 2019

It worked 😅

@rofe rofe closed this as completed Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants