Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[newrelic.js] make email optional #57

Closed
rofe opened this issue Apr 1, 2020 · 2 comments · Fixed by #58
Closed

[newrelic.js] make email optional #57

rofe opened this issue Apr 1, 2020 · 2 comments · Fixed by #58
Assignees
@rofe
Labels
enhancement New feature or request released

Comments

@rofe
Copy link
Collaborator

rofe commented Apr 1, 2020 •
edited

It should be possible to create a monitoring setup without specifying an email for a notification channel. For example, if you just want to add a monitor to an existing alert policy, and you don't want to send alerts to Statuspage.
@rofe rofe added the enhancement New feature or request label Apr 1, 2020
@rofe rofe self-assigned this Apr 1, 2020
@rofe rofe mentioned this issue Apr 2, 2020
Merged
@rofe
Copy link
Collaborator Author

rofe commented Apr 2, 2020

Usage via Orb: if no statuspage_name or statuspage_group is provided, Statuspage integration will be skipped and New Relic integration will be used without email.

@rofe rofe closed this as completed in #58 Apr 2, 2020
rofe added a commit that referenced this issue Apr 2, 2020
@rofe
feat(monitoring): make email optional (#57)
35e188c
adobe-bot pushed a commit that referenced this issue Apr 2, 2020
@semantic-release-bot
chore(release): 1.9.0 [skip ci]
36640ba 
# [1.9.0](v1.8.0...v1.9.0) (2020-04-02)

### Bug Fixes

* **ci:** orb release can fail [skip ci] ([#56](#56)) ([89c6417](89c6417))

### Features

* **monitoring:** make email optional ([#57](#57)) ([35e188c](35e188c))
@adobe-bot
Copy link

🎉 This issue has been resolved in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rofe rofe

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(monitoring): make email optional adobe/helix-ops
2 participants
@rofe @adobe-bot