Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Major action versions for monitoring scripts #67

Closed
tripodsan opened this issue Apr 22, 2020 · 4 comments · Fixed by #68
Closed

Use Major action versions for monitoring scripts #67

tripodsan opened this issue Apr 22, 2020 · 4 comments · Fixed by #68
Assignees
@rofe
Labels
enhancement New feature or request question Further information is requested released

Comments

@tripodsan
Copy link
Contributor

Overview

the current monitoring scripts test the minor versions of the deployed actions,

eg: dispatch@v3.2

Helix internally always uses the major version. so we are testing something that is not actually used.

The following problem can arise:

  • assume dispatcher@v3.2.1 is the latest version
  • v3 -> v3.2.1
  • v3.2 -> v3.2.1

now, we release the next minor version:

  • v3 -> v3.3.0
  • v3.3 -> v3.3.0
  • v3.2 -> v3.2.1

the monitoring scripts get automatically updated during the release and now test @v3.3.

Assume, that the new version causes problems, and we need to immediately switch the v3 link back to v3.2.1. without updating the monitoring scripts, they will continue to test v3.3 (hence v3.3.0) and keep reporting errors.

Proposed Actions

Use the major version only for monitoring scripts.
@tripodsan tripodsan added the question Further information is requested label Apr 22, 2020
@tripodsan
Copy link
Contributor Author

@trieloff @rofe WDYT?

@trieloff
Copy link
Contributor

Agree.

@rofe rofe self-assigned this Apr 22, 2020
@rofe rofe added the enhancement New feature or request label Apr 22, 2020
@rofe rofe mentioned this issue Apr 22, 2020
Merged
@rofe rofe closed this as completed in #68 Apr 22, 2020
rofe added a commit that referenced this issue Apr 22, 2020
@rofe
feat(monitoring): use major action version (#67)
81cd706
adobe-bot pushed a commit that referenced this issue Apr 22, 2020
@semantic-release-bot
chore(release): 1.10.0 [skip ci]
bd7b07d 
# [1.10.0](v1.9.1...v1.10.0) (2020-04-22)

### Features

* **monitoring:** use major action version ([#67](#67)) ([81cd706](81cd706))
@adobe-bot
Copy link

🎉 This issue has been resolved in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rofe
Copy link
Collaborator

rofe commented Apr 23, 2020

Released in CircleCI orb adobe/helix-post-deploy@1.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rofe rofe

Labels
enhancement New feature or request question Further information is requested released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(monitoring): use major action version adobe/helix-ops
4 participants
@trieloff @tripodsan @rofe @adobe-bot