Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

fix(deps): migrate to helix-fetch v2 #738

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Conversation

stefan-guggisberg
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

@github-actions
Copy link

This PR will trigger a patch release when merged.

@stefan-guggisberg
Copy link
Contributor Author

stefan-guggisberg commented Feb 11, 2021

@trieloff There's one test failure when building locally: Integration Test: Test publish function locally
(it succeeds on CI)

I am struggling with PollyJS, i.e. I need to re-record the request but I keep getting Fastly auth error (I used a valid API token). Can you have a look please?

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #738 (503e448) into main (d4ac3b1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #738   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          352       353    +1     
=========================================
+ Hits           352       353    +1     
Impacted Files Coverage Δ
src/check-pkgs.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b5cd2...503e448. Read the comment docs.

@trieloff trieloff mentioned this pull request Feb 11, 2021
@stefan-guggisberg stefan-guggisberg merged commit 798e514 into main Feb 11, 2021
@stefan-guggisberg stefan-guggisberg deleted the helix-fetch-v2 branch February 11, 2021 16:55
@adobe-bot
Copy link
Contributor

🎉 This PR is included in version 8.4.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants