Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

fix(deps): update dependency @adobe/fastly-native-promises to v1.19.6 #97

Closed
wants to merge 8 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 26, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@adobe/fastly-native-promises 1.19.5 -> 1.19.6 age adoption passing confidence

Release Notes

adobe/fastly-native-promises

v1.19.6

Compare Source

Bug Fixes

Renovate configuration

馃搮 Schedule: At any time (no schedule defined).

馃殾 Automerge: Enabled.

鈾伙笍 Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

馃敃 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@github-actions
Copy link

This PR will trigger a patch release when merged.

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #97 (bffd3eb) into main (e075d84) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #97   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           60        60           
=========================================
  Hits            60        60           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e075d84...cca1afc. Read the comment docs.

@tripodsan tripodsan self-assigned this Feb 1, 2021
@tripodsan tripodsan removed their assignment Feb 1, 2021
@tripodsan
Copy link
Contributor

@trieloff I don't know why this fails .. when I run the postdeploy locally, it works.

@trieloff
Copy link
Contributor

trieloff commented Feb 1, 2021

$ curl "https://adobeioruntime.net/api/v1/web/helix/helix-services/purge@ci577?host=theblog--adobe.hlx.page&xfh=blog.adobe.com&path=/en/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html"
[{
  "status": "error",
  "url": "https://theblog--adobe.hlx.page/en/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html"
}, {
  "status": "ok",
  "url": "https://blog.adobe.com/en/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html"
}]

@trieloff
Copy link
Contributor

trieloff commented Feb 1, 2021

$ curl -X PURGE "https://theblog--adobe.hlx.page/en/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html"
{ "status": "ok", "id": "5521-1611857609-4795673" }

@trieloff
Copy link
Contributor

trieloff commented Feb 1, 2021

Maybe it is the missing publish?

curl "https://adobeioruntime.net/api/v1/web/helix/helix-services/purge@ci577?host=theblog--adobe.hlx.page&xfh=blog.adobe.com&path=/en/publish/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html"
[{
  "status": "ok",
  "url": "https://theblog--adobe.hlx.page/en/publish/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html"
}, {
  "status": "ok",
  "url": "https://blog.adobe.com/en/publish/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html"
}]

@trieloff
Copy link
Contributor

trieloff commented Feb 1, 2021

$ curl "https://adobeioruntime.net/api/v1/web/helix/helix-services/purge@ci579?host=theblog--adobe.hlx.page&xfh=blog.adobe.com&path=/en/publish/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html"
[{
  "status": "error",
  "url": "https://theblog--adobe.hlx.page/en/publish/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html"
}, {
  "status": "ok",
  "url": "https://blog.adobe.com/en/publish/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html"
}]%

$ curl "https://adobeioruntime.net/api/v1/web/helix/helix-services/purge@ci579?host=theblog--adobe.hlx.page&xfh=blog.adobe.com&path=/en/publish/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html"
[{
  "status": "ok",
  "url": "https://theblog--adobe.hlx.page/en/publish/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html"
}, {
  "status": "ok",
  "url": "https://blog.adobe.com/en/publish/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html"
}]%

try enough, and it works.

@trieloff
Copy link
Contributor

trieloff commented Feb 1, 2021

The successful and unsuccessful traces on Epsagon look different. It seems that some requests might be cached, so this could be related to the helix-fetch version mismatch.

@trieloff
Copy link
Contributor

trieloff commented Feb 1, 2021

Interesting log message:

"message":"Unable to purge inner CDN FastlyError: { \"status\": \"fail\", \"reason\": \"Batch surrogate key purge request must have surrogate_keys field\" }\n at /nodejsAction/z0MxeF8A/main.js:5072:57\n at processTicksAndRejections (internal/process/task_queues.js:97:5)\n at async purgeInner (/nodejsAction/z0MxeF8A/main.js:77797:5)\n at async main (/nodejsAction/z0MxeF8A/main.js:77856:18)\n at async /nodejsAction/z0MxeF8A/main.js:6689:14\n at async /nodejsAction/z0MxeF8A/main.js:6826:15\n at async /nodejsAction/z0MxeF8A/main.js:24424:24 {\n data: { status: 'fail', reason: 'Batch surrogate key purge request must have surrogate_keys field' },\n code: undefined,\n status: 400\n}"

@trieloff
Copy link
Contributor

trieloff commented Feb 1, 2021

@trieloff
Copy link
Contributor

trieloff commented Feb 1, 2021

With added logging (956fee0), two things become visible:

  1. this is really a Heisenbug, as this build went through: https://app.circleci.com/pipelines/github/adobe/helix-purge/416/workflows/12510e11-89cb-4fd9-8fa1-2a197bebfe86/jobs/589
  2. it does not seem to be an issue of the application, as right before the fetch is issued, following output is logged: https://app.epsagon.com/spans/0ea9a648-4493-7846-3dc6-0294b3c3ba06?tab=1612180245404
{
  "logs": [
    "2021-02-01T11:49:59.738Z       stderr: [INFO] instrumenting epsagon.",
    "2021-02-01T11:49:59.741Z       stderr: [INFO] action-status-begin { container: { uuid: 'e53d5bdcb68f684c19e1ec24d780ea93', numInvocations: 2, begin: { mem: 65429504, age: 28020, concurrency: 1 } } }",
    "2021-02-01T11:49:59.747Z       stderr: [INFO] Purging inner CDN with surrogate key yWVgkTXSpkMMxPok",
    "2021-02-01T11:49:59.749Z       stdout: making HTTP request https://api.fastly.com/service/1McGRQOYFuABWBHyD8D4Ux/purge {\n  method: 'post',\n  headers: {\n    'Fastly-Key': 'XXXXXX',\n    'content-type': 'application/json',\n    'Content-Type': 'application/json'\n  },\n  cache: 'no-store',\n  signal: AbortSignal {\n    [Symbol(AbortSignal internals)]: { eventEmitter: [EventEmitter], onabort: null, aborted: false }\n  },\n  body: '{\"surrogate_keys\":[\"yWVgkTXSpkMMxPok\"]}'\n}",
    "2021-02-01T11:49:59.771Z       stderr: [INFO] Purging https://blog.adobe.com/en/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html",
    "2021-02-01T11:49:59.787Z       stderr: [INFO] Purging https://blog.adobe.com/en/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic",
    "2021-02-01T11:49:59.797Z       stderr: [INFO] action-status-end { container: { uuid: 'e53d5bdcb68f684c19e1ec24d780ea93', numInvocations: 2, begin: { mem: 65429504, age: 28020, concurrency: 1 }, end: { mem: 65761280, age: 28076, concurrency: 1 }, delta: { mem: 331776, age: 56 } } }"
  ]
}

i.e. the body is clearly there.

@trieloff
Copy link
Contributor

trieloff commented Feb 1, 2021

@trieloff
Copy link
Contributor

trieloff commented Feb 1, 2021

v1.5.10 is working consistently, since v1.5.11 it's failing occasionally - always the same error. The biggest change: switch to node 12.

@trieloff
Copy link
Contributor

trieloff commented Feb 2, 2021

馃帀 This issue has been resolved in version 1.5.13 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

@stefan-guggisberg
Copy link
Contributor

The successful and unsuccessful traces on Epsagon look different. It seems that some requests might be cached, so this could be related to the helix-fetch version mismatch.

FWIW: It can't be a cache issue. Only GET and HEAD requests are potentially cached.

@renovate renovate bot deleted the renovate-adobe-fixes branch February 15, 2021 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants