Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

chore: migrate to helix-fetch v2 #347

Merged
merged 1 commit into from
Jan 28, 2021
Merged

chore: migrate to helix-fetch v2 #347

merged 1 commit into from
Jan 28, 2021

Conversation

stefan-guggisberg
Copy link
Collaborator

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

@stefan-guggisberg
Copy link
Collaborator Author

related to adobe/helix-home#182

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #347 (99229f8) into main (9e621c6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #347   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           25        25           
=========================================
  Hits            25        25           
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e621c6...99229f8. Read the comment docs.

Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was it necessary to re-record the requests?

@stefan-guggisberg
Copy link
Collaborator Author

why was it necessary to re-record the requests?

Dunno. I got polly errors that recordings couldn't be found and that recordIfMissing was false. When I temporarily enabled recordIfMissing the errors went away.

@stefan-guggisberg stefan-guggisberg merged commit 770f71a into main Jan 28, 2021
@stefan-guggisberg stefan-guggisberg deleted the helix-fetch-v2 branch January 28, 2021 09:23
@adobe-bot
Copy link
Contributor

🎉 This PR is included in version 1.8.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants