Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update external major to v8 (major) #518

Merged
merged 3 commits into from
Oct 18, 2021
Merged

chore(deps): update external major to v8 (major) #518

merged 3 commits into from
Oct 18, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 11, 2021 •
edited

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) 7.32.0 -> 8.0.0 age adoption passing confidence
npm (source) 7.24.1 -> 8.0.0 age adoption passing confidence

Release Notes

eslint/eslint

v8.0.0

Compare Source

npm/cli

v8.0.0

Compare Source

The purpose of this release is to drop support for old node versions and
to remove support for require('npm'). There are no other breaking
changes.

BREAKING CHANGES
  • Drop support for node 10 and 11
  • Raise support ceiling in node 12 and 14 to LTS (^12.13.0/^14.15.0)
  • Drop support to require('npm')
  • Update subdependencies that also dropped node10 support
DEPENDENCIES
  • The following dependencies were updated to drop node10 support and
    update to the latest node-gyp
    • libnpmversion@2.0.1
    • pacote@12.0.0
    • libnpmpack@3.0.0
    • @​npmcli/arborist@​3.0.0
    • libnpmfund@2.0.0
    • libnpmexec@3.0.0
    • node-gyp@8.2.0
  • 8bd85cdae
    #​3813
    cli-columns@4.0.0

v7.24.2

Compare Source

v7.24.2 (2021-10-04)
BUG FIXES
DEPENDENCIES
  • 69ab10bbf is-core-module@2.7.0
  • e94ddeaca @npmcli/arborist@2.9.0:
    • fix: avoid infinite loops in peer dep replacements
    • fix: use Intl.Collator for string sorting when available
    • feat(vuln): expose isDirect
DOCUMENTATION

Configuration

📅 Schedule: "after 2pm on Monday" in timezone Europe/Zurich.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@github-actions
Copy link

This PR will trigger no release when merged.

@trieloff
Copy link
Contributor 

#!/bin/bash -eo pipefail
npm run lint

> @adobe/helix-run-query@2.21.5 lint
> ./node_modules/.bin/eslint .


Oops! Something went wrong! :(

ESLint: 8.0.0

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/util/glob-util' is not defined by "exports" in /home/circleci/repo/node_modules/eslint/package.json
    at new NodeError (internal/errors.js:322:7)
    at throwExportsNotFound (internal/modules/esm/resolve.js:322:9)
    at packageExportsResolve (internal/modules/esm/resolve.js:545:3)
    at resolveExports (internal/modules/cjs/loader.js:450:36)
    at Function.Module._findPath (internal/modules/cjs/loader.js:490:31)
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:888:27)
    at Function.Module._load (internal/modules/cjs/loader.js:746:27)
    at Module.require (internal/modules/cjs/loader.js:974:19)
    at require (/home/circleci/repo/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at Object.<anonymous> (/home/circleci/repo/node_modules/eslint-plugin-import/lib/rules/no-unused-modules.js:43:34)

Exited with code exit status 2
CircleCI received exit code 2

@trieloff
Copy link
Contributor

Caused by import-js/eslint-plugin-import#2252

@codecov
Copy link

codecov bot commented Oct 18, 2021 •
edited

Codecov Report

Merging #518 (d6ba886) into main (d138086) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #518   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          141       141           
=========================================
  Hits           141       141

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d138086...d6ba886. Read the comment docs.

@tripodsan tripodsan merged commit 6848165 into main Oct 18, 2021
@tripodsan tripodsan deleted the renovate-major-external-major branch October 18, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trieloff @tripodsan @renovate-bot @adobe-bot