Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): add copy options for addMetadata #975

Merged
merged 4 commits into from
Jul 16, 2024
Merged

fix(storage): add copy options for addMetadata #975

merged 4 commits into from
Jul 16, 2024

Conversation

maxakuru
Copy link
Member

@maxakuru maxakuru requested a review from tripodsan July 15, 2024 15:44
@maxakuru maxakuru changed the title fix(storage): add copy options for addMetdata fix(storage): add copy options for addMetadata Jul 15, 2024
Copy link
Contributor

@tripodsan tripodsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guard against NPE

packages/helix-shared-storage/src/storage.js Outdated Show resolved Hide resolved
packages/helix-shared-storage/src/storage.js Outdated Show resolved Hide resolved
Co-authored-by: Tobias Bocanegra <tripod@adobe.com>
Copy link

This PR will trigger a patch release when merged.

@maxakuru maxakuru requested a review from tripodsan July 16, 2024 14:46
@maxakuru maxakuru requested a review from tripodsan July 16, 2024 15:11
@maxakuru maxakuru merged commit 58e4db1 into main Jul 16, 2024
8 checks passed
@maxakuru maxakuru deleted the copy-opts branch July 16, 2024 20:41
adobe-bot pushed a commit that referenced this pull request Jul 16, 2024
# [@adobe/helix-shared-storage-v1.0.3](https://github.com/adobe/helix-shared/compare/@adobe/helix-shared-storage-v1.0.2...@adobe/helix-shared-storage-v1.0.3) (2024-07-16)

### Bug Fixes

* **storage:** add copy options for addMetadata ([#975](#975)) ([58e4db1](58e4db1))
@adobe-bot
Copy link

🎉 This PR is included in version @adobe/helix-shared-storage-v1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants