Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use /helix-env.json to add projects #100

Closed
Tracked by #4
rofe opened this issue Jun 13, 2022 · 3 comments · Fixed by #87
Closed
Tracked by #4

Use /helix-env.json to add projects #100

rofe opened this issue Jun 13, 2022 · 3 comments · Fixed by #87
Labels
enhancement New feature or request mv3

Comments

@rofe
Copy link
Contributor

rofe commented Jun 13, 2022 •
edited
Loading

The sidekick extension currently uses GH's raw API to extract project information from the GitHub repo. This is a bit shaky and doesn't work if repositories are private. It would be much better to use the new setup API.

Update: /helix-env.json already provides what the sidekick needs to add a project.
@rofe rofe added the enhancement New feature or request label Jun 13, 2022
@rofe rofe changed the title Use setup API to add projects Use /helix-env.json to add projects Jun 25, 2022
@rofe rofe mentioned this issue Jun 25, 2022
Closed
6 tasks
rofe added a commit that referenced this issue Jun 27, 2022
@rofe
feat: use helix-env.json to add project #100
1a48b08 
feat: use hlx:proxyUrl for local dev #102
@rofe
Copy link
Contributor Author

rofe commented Jun 27, 2022

/helix-env.json should exist from the start, see https://github.com/adobe/helix-admin/issues/671

@rofe
Copy link
Contributor Author

rofe commented Jun 27, 2022

Implemented in mv3 branch

@rofe rofe closed this as completed Jun 27, 2022
@rofe
Copy link
Contributor Author

rofe commented Jul 6, 2022

For this to work with new projects, https://github.com/adobe/helix-admin/issues/671 is required.

@rofe rofe reopened this Jul 6, 2022
@rofe rofe closed this as completed Jul 11, 2022
@rofe rofe reopened this Sep 5, 2022
This was referenced Sep 5, 2022
Merged
Merged
@rofe rofe added the mv3 label Oct 23, 2022
@rofe rofe closed this as completed in #87 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request mv3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: migrate to manifest v3 adobe/helix-sidekick-extension
1 participant
@rofe