Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Sidekick does not detect CI build domain in preview URL #67

Closed
rofe opened this issue Aug 19, 2021 · 1 comment · Fixed by #68
Closed

Sidekick does not detect CI build domain in preview URL #67

rofe opened this issue Aug 19, 2021 · 1 comment · Fixed by #68
Assignees
Labels
bug Something isn't working released

Comments

@rofe
Copy link
Contributor

rofe commented Aug 19, 2021

When launching the sidekick on a CI/branch deployment of helix-pages (e.g. *.hlx-1.page), it doesn't recognize the URL as a preview URL and loads the config.js from the fallback *.hlx.page, which works, but subsequent CORS-bound requests made from within the config.js, such as loading one of the project's JS modules, will fail.

@rofe rofe added the bug Something isn't working label Aug 19, 2021
@rofe rofe self-assigned this Aug 19, 2021
@rofe rofe closed this as completed in #68 Aug 20, 2021
@trieloff
Copy link

🎉 This issue has been resolved in version 3.7.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants