Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Add surrogate-key response header #8

Closed
tripodsan opened this issue Jun 13, 2019 · 0 comments · Fixed by #20
Closed

Add surrogate-key response header #8

tripodsan opened this issue Jun 13, 2019 · 0 comments · Fixed by #20
Assignees
@tripodsan

Comments

@tripodsan
Copy link
Contributor

In order to be able to invalidate the cache when a github resource has changed, it would be helpful to use a surrogate-key. this is easier than compute all potential external URLs of a static resource.

Suggestion

  • compute the surrogate hash similar to helix-pipeline based on the raw github url of the loaded resource.
  • add the surrogate hash to the Surrogate-Key response header.
@tripodsan tripodsan mentioned this issue Jun 18, 2019
Closed
@tripodsan tripodsan self-assigned this Jul 2, 2019
tripodsan added a commit that referenced this issue Jul 11, 2019
@tripodsan
fix(caching): add surrogate key
02d72fa 
fixes #8
@tripodsan tripodsan mentioned this issue Jul 11, 2019
Merged
tripodsan added a commit that referenced this issue Jul 18, 2019
@tripodsan
fix(caching): add surrogate key (#20)
97212a1 
fixes #8
adobe-bot pushed a commit that referenced this issue Jul 18, 2019
@semantic-release-bot
chore(release): 1.2.4 [skip ci]
ad53dad 
## [1.2.4](v1.2.3...v1.2.4) (2019-07-18)

### Bug Fixes

* **caching:** add surrogate key ([#20](#20)) ([97212a1](97212a1)), closes [#8](#8)
@adobe-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.2.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

3 similar comments
@adobe-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.2.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@adobe-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.2.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@adobe-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.2.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tripodsan tripodsan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(caching): add surrogate key adobe/helix-static
2 participants
@tripodsan @adobe-bot