Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#230] block side navigation ux - without search #241

Merged
merged 4 commits into from
May 25, 2023

Conversation

nicolerego
Copy link
Collaborator

@nicolerego nicolerego added the redesign Task related to the website redesign label May 25, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented May 25, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented May 25, 2023

@nicolerego
Copy link
Collaborator Author

Received direction from Kiel for mobile - will work on this today.

@aem-code-sync
Copy link

aem-code-sync bot commented May 25, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented May 25, 2023

@solomon71
Copy link
Collaborator

@nicolerego able to fix the styles.css conflict?

@aem-code-sync
Copy link

aem-code-sync bot commented May 25, 2023

@nicolerego
Copy link
Collaborator Author

@solomon71 just resolved the merge conflict in styles.css

@@ -642,7 +645,7 @@ export function buildAutoBlocks(main) {
export function decorateMain(main) {
buildAutoBlocks(main);
decorateSections(main);
decorateButtons(main);
// decorateButtons(main);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this (comment out decorate buttons) temporary @nicolerego?

@solomon71 solomon71 merged commit e261d8b into website-redesign May 25, 2023
3 checks passed
@solomon71 solomon71 deleted the redesign/documentation-nav branch May 25, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redesign Task related to the website redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants