fix(rum-explorer): conversion specs should operate on facets, not on raw properties #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akalfas
reviewed
Jun 14, 2024
tools/rum/test/cruncher.test.js
Outdated
| @@ -768,6 +768,8 @@ describe('DataChunks.hasConversion', () => { | |||
| checkpoint: ['top'], | |||
There was a problem hiding this comment.
What if we write the test something like
const spec = {
facetOne: ['top'],
facetTwo: ['hidden'],
};
d.addFacet('facetOne', (bundle) => bundle.events.map((e) => e.checkpoint));
d.addFacet('facetTwo', (bundle) => bundle.events.map((e) => e.target));
This way it would be more clear that conversions work with facets not bundle events.
akalfas
reviewed
Jun 14, 2024
tools/rum/cruncher.js
Outdated
| @@ -562,11 +562,20 @@ export class DataChunks { | |||
| hasConversion(aBundle, filterSpec, combiner) { | |||
| const existenceFilterFn = () => true; | |||
There was a problem hiding this comment.
If this operates with facets - no need to have a different function then filterBundles
chore(rum-explorer): test that reflects how conversion works - facets…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.