Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling Vault SSL verify #49

Closed
aslafy-z opened this issue Apr 9, 2021 · 2 comments · Fixed by #46
Closed

Allow disabling Vault SSL verify #49

aslafy-z opened this issue Apr 9, 2021 · 2 comments · Fixed by #46

Comments

@aslafy-z
Copy link
Contributor

aslafy-z commented Apr 9, 2021

Expected Behaviour

VAULT_SKIP_VERIFY=1 himl myvaultyaml.yaml

=> Just works

Actual Behaviour

requests.exceptions.SSLError: HTTPSConnectionPool(host='vault.xx.com', port=443): Max retries exceeded with url: /v1/auth/token/lookup-self (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1125)')))

@costimuraru
Copy link
Contributor

@aslafy-z is this something we really want? Skipping the certificate validation for a secret store pretty much renders the security model ineffective.

@danielcoman
Copy link
Contributor

@costimuraru This is supported by the upstream vault client, I think we should expose it as-well. Can be useful for dev.
@aslafy-z What I think should be change is the SSL warning suppression. It should be clear what the connection state is and the warning presented to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants