Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vault): allow passing down VAULT_SKIP_VERIFY #46

Merged
merged 4 commits into from
Apr 23, 2021

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Apr 9, 2021

Description

Allow disabling Vault SSL validation.

Related Issue

Fixes #49

Motivation and Context

This allows disabling SSL verification when working with non-trusted self-signed certificates when prototyping.

How Has This Been Tested?

  • Set VAULT_ADDR to a self-signed non trusted certificate backed vault instance
  • Set VAULT_SKIP_VERIFY=false
  • Run himl with a vault secret
  • Raises with error: requests.exceptions.SSLError: HTTPSConnectionPool(host='vault.xx.com', port=443): Max retries exceeded with url: /v1/auth/token/lookup-self (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1125)')))
  • Current functionnality is retained

================

  • Set VAULT_ADDR to a self-signed non trusted certificate backed vault instance
  • Set VAULT_SKIP_VERIFY=true
  • Run himl with a vault secret
  • Works
  • Current functionnality is retained

================

  • Set VAULT_ADDR to a self-signed trusted certificate backed vault instance
  • Run himl with a vault secret
  • Works
  • Current functionnality is retained

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aslafy-z aslafy-z closed this Apr 9, 2021
@aslafy-z aslafy-z reopened this Apr 9, 2021
@aslafy-z aslafy-z marked this pull request as ready for review April 9, 2021 13:48
@aslafy-z aslafy-z changed the title WIP: feat(vault): allow passing down VAULT_SKIP_VERIFY feat(vault): allow passing down VAULT_SKIP_VERIFY Apr 9, 2021
himl/simplevault.py Outdated Show resolved Hide resolved
@danielcoman danielcoman merged commit 78f7273 into adobe:master Apr 23, 2021
@aslafy-z aslafy-z deleted the patch-1 branch April 23, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disabling Vault SSL verify
2 participants