Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unintentional fallthrough when determining storage class of function #28

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Fix unintentional fallthrough when determining storage class of function #28

merged 1 commit into from
Nov 27, 2018

Conversation

mmha
Copy link
Contributor

@mmha mmha commented Nov 23, 2018

No description provided.

@fosterbrereton
Copy link
Contributor

Hey @mmha, thank you for the contribution! We won't be able to accept it until you've signed the Adobe CLA. Once you've done that let us know, and then we'll be able to merge the PR.

fosterbrereton
fosterbrereton requested changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@fosterbrereton fosterbrereton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM; Needs CLA approval.

@mmha
Copy link
Contributor Author

mmha commented Nov 27, 2018

Can you double check that? I did sign the CLA before I submitted that PR.

@fosterbrereton
Copy link
Contributor

Yes, I'm happy to. It's a bit of a manual process on this end (which we need to improve upon.)

@fosterbrereton fosterbrereton merged commit 4b49912 into adobe:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fosterbrereton fosterbrereton fosterbrereton requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmha @fosterbrereton