Make sure all elements get validated/updated #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use underscore for multi-word keys - Make sure removed keys are handled properly - Reenable annotation and tags elements - Differentiate annotation for explicitly defaulted vs implicitly (compiler) defaulted members - Differentiate annotation for explicitly deleted vs implicitly (compiler) deleted members
…nerated. Ensure all expected elements are checked.
fosterbrereton
approved these changes
Mar 9, 2020
| @@ -442,8 +675,13 @@ bool yaml_base_emitter::check_object_array(const std::string& filepath, | |||
| }; | |||
|
|
|||
| if (!expected_node.count(key)) { | |||
There was a problem hiding this comment.
This check looks like it could be generalized into a routine and called from the multiple check_* APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure all elements get validated/updated.
Before, many elements generated as part of the non-editable documentation weren't checked during yaml emit. This meant that many elements of Hyde documentation that have changed over time or where the header declarations changed were never updated in existing documentation. Also, extraneous elements were never removed from many elements.
Also:
defined-in-fileelement for consistency