Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation passing even when sourcefile doc is invalid #65

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

baheath
Copy link
Collaborator

@baheath baheath commented Nov 19, 2020

Need to fail when sourcefile validation fails.

Copy link
Contributor

@fosterbrereton fosterbrereton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fosterbrereton fosterbrereton merged commit 5771cbf into master Nov 19, 2020
@fosterbrereton fosterbrereton deleted the bheath/sourcefile-failure branch November 19, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants