Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to gocron v2 and fix flaky ci #198

Merged
merged 3 commits into from
May 17, 2024
Merged

Switch to gocron v2 and fix flaky ci #198

merged 3 commits into from
May 17, 2024

Conversation

adriananeci
Copy link
Contributor

@adriananeci adriananeci commented May 17, 2024

Bump gocron to v2 and attempt to fix the flaky TestNodeIsCleanedUp e2e test.

Related Issue

Motivation and Context

How Has This Been Tested?

Tested it locally, some logs snippets

time="2024-05-17T09:41:25Z" level=info msg="K8s-shredder info" BuildTime= GitSHA=45dfbde Version=dev-45dfbde
time="2024-05-17T09:41:25Z" level=info msg="Initializing metrics server"
time="2024-05-17T09:41:25Z" level=info msg="Loaded configuration" AllowEvictionLabel=shredder.ethos.adobe.net/allow-eviction EvictionLoopInterval=10s ExpiresOnLabel=shredder.ethos.adobe.net/parked-node-expires-on NamespacePrefixSkipInitialEviction=ns-ethos- ParkedNodeTTL=30s RestartedAtAnnotation=shredder.ethos.adobe.net/restartedAt RollingRestartThreshold=0.5 ToBeDeletedTaint=ToBeDeletedByClusterAutoscaler UpgradeStatusLabel=shredder.ethos.adobe.net/upgrade-status
time="2024-05-17T09:41:25Z" level=info msg="Configured scheduler job with ID: 883615f4-1eb7-4089-a29a-ac1bebdbacba"
time="2024-05-17T09:41:25Z" level=info msg="Active jobs: [883615f4-1eb7-4089-a29a-ac1bebdbacba]"
time="2024-05-17T09:41:25Z" level=info msg="Scheduler started, happy shredding!"
time="2024-05-17T09:41:35Z" level=info msg="Starting eviction loop" dryRun=false
time="2024-05-17T09:41:45Z" level=info msg="Starting eviction loop" dryRun=false
time="2024-05-17T09:41:45Z" level=info msg="Processing node k8s-shredder-test-cluster-worker" dryRun=false
time="2024-05-17T09:41:45Z" level=info msg="Evicting pod test-app-caas-5559dcc49d-rtn62 from ns-k8s-shredder-test namespace" dryRun=false
time="2024-05-17T09:41:45Z" level=info msg="Evicting pod test-app-caas-5559dcc49d-sc8tf from ns-k8s-shredder-test namespace" dryRun=false
time="2024-05-17T09:41:45Z" level=info msg="Evicting pod test-app-allow-eviction-5c964d4b75-kvf2d from ns-team-k8s-shredder-test namespace" dryRun=false
time="2024-05-17T09:41:45Z" level=info msg="Evicting pod test-app-allow-eviction-5c964d4b75-q6m4r from ns-team-k8s-shredder-test namespace" dryRun=false
time="2024-05-17T09:44:54Z" level=info msg="Configuration file `/k8s-shredder-config/..2024_05_17_09_44_54.4115186607` changed, attempting to reload"
time="2024-05-17T09:44:54Z" level=info msg="Loaded configuration" AllowEvictionLabel=shredder.ethos.adobe.net/allow-eviction EvictionLoopInterval=10s ExpiresOnLabel=shredder.ethos.adobe.net/parked-node-expires-on NamespacePrefixSkipInitialEviction=ns-ethos- ParkedNodeTTL=31s RestartedAtAnnotation=shredder.ethos.adobe.net/restartedAt RollingRestartThreshold=0.5 ToBeDeletedTaint=ToBeDeletedByClusterAutoscaler UpgradeStatusLabel=shredder.ethos.adobe.net/upgrade-status
time="2024-05-17T09:44:54Z" level=info msg="Configured scheduler job with ID: 44223ce1-d7b4-407a-879b-9cebe493af9f"
time="2024-05-17T09:44:54Z" level=info msg="Active jobs: [44223ce1-d7b4-407a-879b-9cebe493af9f]"

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@adriananeci adriananeci requested a review from a team as a code owner May 17, 2024 09:50
@adriananeci adriananeci changed the title Switch to gocron v2 and fix flaky ci Switch to gocron v2, bump chart version and fix flaky ci May 17, 2024
@adriananeci adriananeci changed the title Switch to gocron v2, bump chart version and fix flaky ci Switch to gocron v2 and fix flaky ci May 17, 2024
Copy link

@JonnieDoe JonnieDoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@aalexandru aalexandru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adriananeci adriananeci merged commit bd6f9b0 into main May 17, 2024
4 checks passed
@adriananeci adriananeci deleted the gocron_v2 branch May 17, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants