Use local replacement for sub-modules #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929.
alex-necula
previously approved these changes
Mar 28, 2023
|
LGTM |
alex-necula
approved these changes
Mar 28, 2023
amuraru
approved these changes
Apr 6, 2023
amuraru
pushed a commit
that referenced
this pull request
May 16, 2023
As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929.
ctrlaltluc
added a commit
that referenced
this pull request
May 19, 2023
* [INTERNAL] [BUILD] Publish docker images to adobe/kafka-operator and adobe/kafka docker hub repos - build the koperator docker image - build Apache kafka docker image When `kafka-*` tags are created a github action is triggered to build and push a new adobe/kafka docker image version * [INTERNAL] make manifests should be called manually, if needed (#25) We made some chnages for spinnaker annotations and `preserveUnknownFields` that would be overriden by `make manifests` * [INTERNAL] Allow Kafka to use External DNS for inter-broker protocol (#17) (#22) * [INTERNAL] Allow external listeners to be used for inner communication (#26) * [INTERNAL] Ensure external listerners are always the first the advertised.listeners configuration This is needed for old clients connecting to kafka through Zookeeper that does not have a way to infer the right listener. In this case, the first listener in the advertised.listener config is used to connect to brokers. This patch ensures the external listeners (those reachable from outside) are listed before internal ones * [INTERNAL] Generate CRDs resources * [INTERNAL] Upgrade to Kafka 2.8.1 (#36) * Enable envoy idleTimeout and TCP keep-alive for connections to kafka and clients 1/ Kafka broker defines connections.max.idle.ms=600s To ensure envoy as a client for kafka broker is terminating the connection first to avoid network disconnects this patch is setting the idleTimeout to value slightly less than that 2/ Enable tcp-keep alive for all TCP connections established by envoy to kafka and to client (or fronting Load Balancer) * Enable envoy tls termination (#41) * [INTERNAL] Build kafka 3.1.1 using Oracle OpenJDK * Envoy config generated by the operator is invalid in envoy 1.22 Added explicit typeconfig for envoy.filters.http.router ``` [2022-06-16 13:27:58.425][1][info][main] [source/server/server.cc:939] exiting Didn't find a registered implementation for 'envoy.filters.http.router' with type URL: '' ``` * Added TaintedBrokersSelector to kafkaClusterSpec (#48) Co-authored-by: Adrian Muraru <adi.muraru@gmail.com> * Build kafka 3.2.2 * Upgrade kafka to 3.2.3 * Upgrade kafka to 3.3.1 * [Internal] Update helm for adobe builds (#52) * [INTERNAL] Use local replacement for sub-modules (#54) As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929. * Upgrade kafka to 3.4.0 --------- Co-authored-by: Adi Muraru <amuraru@adobe.com> Co-authored-by: Adrian Lungu <adrian.lungu89@gmail.com> Co-authored-by: Razvan Dobre <dobre.razvan@gmail.com> Co-authored-by: Adrian Muraru <adi.muraru@gmail.com> Co-authored-by: Adrian Coman <acoman@adobe.com> Co-authored-by: aguzovatii <guzovatii.anatolii@gmail.com>
ctrlaltluc
pushed a commit
that referenced
this pull request
Jun 8, 2023
As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929.
ctrlaltluc
added a commit
that referenced
this pull request
Jun 8, 2023
* [INTERNAL] [BUILD] Publish docker images to adobe/kafka-operator and adobe/kafka docker hub repos - build the koperator docker image - build Apache kafka docker image When `kafka-*` tags are created a github action is triggered to build and push a new adobe/kafka docker image version * [INTERNAL] make manifests should be called manually, if needed (#25) We made some chnages for spinnaker annotations and `preserveUnknownFields` that would be overriden by `make manifests` * [INTERNAL] Allow Kafka to use External DNS for inter-broker protocol (#17) (#22) * [INTERNAL] Allow external listeners to be used for inner communication (#26) * [INTERNAL] Ensure external listerners are always the first the advertised.listeners configuration This is needed for old clients connecting to kafka through Zookeeper that does not have a way to infer the right listener. In this case, the first listener in the advertised.listener config is used to connect to brokers. This patch ensures the external listeners (those reachable from outside) are listed before internal ones * [INTERNAL] Generate CRDs resources * [INTERNAL] Upgrade to Kafka 2.8.1 (#36) * Enable envoy idleTimeout and TCP keep-alive for connections to kafka and clients 1/ Kafka broker defines connections.max.idle.ms=600s To ensure envoy as a client for kafka broker is terminating the connection first to avoid network disconnects this patch is setting the idleTimeout to value slightly less than that 2/ Enable tcp-keep alive for all TCP connections established by envoy to kafka and to client (or fronting Load Balancer) * Enable envoy tls termination (#41) * [INTERNAL] Build kafka 3.1.1 using Oracle OpenJDK * Envoy config generated by the operator is invalid in envoy 1.22 Added explicit typeconfig for envoy.filters.http.router ``` [2022-06-16 13:27:58.425][1][info][main] [source/server/server.cc:939] exiting Didn't find a registered implementation for 'envoy.filters.http.router' with type URL: '' ``` * Added TaintedBrokersSelector to kafkaClusterSpec (#48) Co-authored-by: Adrian Muraru <adi.muraru@gmail.com> * Build kafka 3.2.2 * Upgrade kafka to 3.2.3 * Upgrade kafka to 3.3.1 * [Internal] Update helm for adobe builds (#52) * [INTERNAL] Use local replacement for sub-modules (#54) As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929. * Upgrade kafka to 3.4.0 --------- Co-authored-by: Adi Muraru <amuraru@adobe.com> Co-authored-by: Adrian Lungu <adrian.lungu89@gmail.com> Co-authored-by: Razvan Dobre <dobre.razvan@gmail.com> Co-authored-by: Adrian Muraru <adi.muraru@gmail.com> Co-authored-by: Adrian Coman <acoman@adobe.com> Co-authored-by: aguzovatii <guzovatii.anatolii@gmail.com>
ctrlaltluc
pushed a commit
that referenced
this pull request
Jun 8, 2023
As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929.
ctrlaltluc
added a commit
that referenced
this pull request
Jun 8, 2023
* [INTERNAL] [BUILD] Publish docker images to adobe/kafka-operator and adobe/kafka docker hub repos - build the koperator docker image - build Apache kafka docker image When `kafka-*` tags are created a github action is triggered to build and push a new adobe/kafka docker image version * [INTERNAL] make manifests should be called manually, if needed (#25) We made some chnages for spinnaker annotations and `preserveUnknownFields` that would be overriden by `make manifests` * [INTERNAL] Allow Kafka to use External DNS for inter-broker protocol (#17) (#22) * [INTERNAL] Allow external listeners to be used for inner communication (#26) * [INTERNAL] Ensure external listerners are always the first the advertised.listeners configuration This is needed for old clients connecting to kafka through Zookeeper that does not have a way to infer the right listener. In this case, the first listener in the advertised.listener config is used to connect to brokers. This patch ensures the external listeners (those reachable from outside) are listed before internal ones * [INTERNAL] Generate CRDs resources * [INTERNAL] Upgrade to Kafka 2.8.1 (#36) * Enable envoy idleTimeout and TCP keep-alive for connections to kafka and clients 1/ Kafka broker defines connections.max.idle.ms=600s To ensure envoy as a client for kafka broker is terminating the connection first to avoid network disconnects this patch is setting the idleTimeout to value slightly less than that 2/ Enable tcp-keep alive for all TCP connections established by envoy to kafka and to client (or fronting Load Balancer) * Enable envoy tls termination (#41) * [INTERNAL] Build kafka 3.1.1 using Oracle OpenJDK * Envoy config generated by the operator is invalid in envoy 1.22 Added explicit typeconfig for envoy.filters.http.router ``` [2022-06-16 13:27:58.425][1][info][main] [source/server/server.cc:939] exiting Didn't find a registered implementation for 'envoy.filters.http.router' with type URL: '' ``` * Added TaintedBrokersSelector to kafkaClusterSpec (#48) Co-authored-by: Adrian Muraru <adi.muraru@gmail.com> * Build kafka 3.2.2 * Upgrade kafka to 3.2.3 * Upgrade kafka to 3.3.1 * [Internal] Update helm for adobe builds (#52) * [INTERNAL] Use local replacement for sub-modules (#54) As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929. * Upgrade kafka to 3.4.0 --------- Co-authored-by: Adi Muraru <amuraru@adobe.com> Co-authored-by: Adrian Lungu <adrian.lungu89@gmail.com> Co-authored-by: Razvan Dobre <dobre.razvan@gmail.com> Co-authored-by: Adrian Muraru <adi.muraru@gmail.com> Co-authored-by: Adrian Coman <acoman@adobe.com> Co-authored-by: aguzovatii <guzovatii.anatolii@gmail.com>
amuraru
pushed a commit
that referenced
this pull request
Jun 10, 2023
As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929.
amuraru
pushed a commit
that referenced
this pull request
Dec 12, 2023
As part of banzaicloud#929, the local replacement for sub-modules was removed in favor of using valid tags. Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, so we are forced to revert the changes from banzaicloud#929.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
As part of #929, the local replacement for sub-modules was removed in favor of using valid tags.
Adobe Koperator fork has some internal changes in the api sub-module, so we need to use the local version of the sub-module instead of the upstream version, this forces us to revert the changes from #929.
Why?
Additional context
Checklist
To Do