Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/cover auto running singleton classes #47

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Bug/cover auto running singleton classes #47

merged 2 commits into from
Jul 17, 2018

Conversation

atrifan
Copy link
Collaborator

@atrifan atrifan commented Jul 16, 2018 •
edited
Loading

Description

This is the fix for auto running classes - matching some sort of singleton pattern. It's partially fixing issue 28

Partially fix for #28

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have signed the Adobe CLA
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@atrifan atrifan mentioned this pull request Jul 17, 2018
Closed
andralungu
andralungu approved these changes Jul 17, 2018
View reviewed changes
Copy link

@andralungu andralungu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@atrifan atrifan merged commit 6359f55 into develop Jul 17, 2018
@atrifan atrifan deleted the bug/cover_auto_running_singleton_classes branch July 17, 2018 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andralungu andralungu andralungu approved these changes

@corinapurcarea corinapurcarea Awaiting requested review from corinapurcarea

@vdatcu vdatcu Awaiting requested review from vdatcu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atrifan @andralungu