Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing ansible cli extra_vars #154

Merged
merged 1 commit into from Oct 12, 2023
Merged

Fix missing ansible cli extra_vars #154

merged 1 commit into from Oct 12, 2023

Conversation

asalajan
Copy link
Contributor

Description

Motivation and Context

Ansible cli extra_vars (-e var=value) were not actually used due to some caching issues

How Has This Been Tested?

Updated the tests with specific case which was not covered before

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@asalajan asalajan merged commit 5c47f33 into adobe:master Oct 12, 2023
3 checks passed
@asalajan asalajan deleted the fix_extra_vars branch October 12, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefangusa stefangusa stefangusa approved these changes

@grigoriuionut grigoriuionut grigoriuionut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asalajan @stefangusa @grigoriuionut