Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVEP-2794: Don't change remote image paths if download fails #5

Merged
merged 6 commits into from
Jun 4, 2021

Conversation

macdonst
Copy link
Contributor

@macdonst macdonst commented Jun 4, 2021

Description

Catches invalid image download results

Related Issue

DEVEP-2794

Motivation and Context

Some remote images linked via the docs may not be accessible to our build project so instead of having the downloader have an invalid image file it catches these errors and leaves the markdown unchanged.

How Has This Been Tested?

Added test cases
Ran markdown cleaner against a failing repo

Screenshots (if appropriate):

n/a

Types of changes

  • [x Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@macdonst macdonst requested a review from hirenoble June 4, 2021 20:07
@macdonst macdonst merged commit e9edb3c into main Jun 4, 2021
@macdonst macdonst deleted the DEVEP-2794 branch June 4, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants