-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gtonkinson/animations #132
Conversation
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-132 |
const ref = useRef<T>(); | ||
const previousDataRef = useRef<T>(); | ||
|
||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is surprisingly elegant for a useEffect
, good job
src/stories/Chart.story.tsx
Outdated
@@ -28,7 +28,7 @@ export default { | |||
const ChartLineStory: StoryFn<typeof Chart> = (args): ReactElement => { | |||
const props = useChartProps(args); | |||
return ( | |||
<Chart {...props}> | |||
<Chart {...props} debug> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick revert on this
Quality Gate passedIssues Measures |
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-132 |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: