Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nathaniel judd/byu team/animations #153

Merged
merged 12 commits into from
Mar 1, 2024
Merged

Nathaniel judd/byu team/animations #153

merged 12 commits into from
Mar 1, 2024

Conversation

Judd2000
Copy link
Collaborator

No description provided.

jacob-hart
jacob-hart requested changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@jacob-hart jacob-hart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get the linter happy before merging in. You can do yarn lint locally to see what the complaints are

src/VegaChart.tsx Outdated Show resolved Hide resolved
src/VegaChart.tsx Outdated Show resolved Hide resolved
src/specBuilder/specUtils.ts Outdated Show resolved Hide resolved
src/specBuilder/specUtils.ts Outdated Show resolved Hide resolved
src/stories/components/Line/Line.test.tsx Outdated Show resolved Hide resolved
@Judd2000 Judd2000 merged commit a3c56d9 into animations Mar 1, 2024
3 of 4 checks passed
@Judd2000 Judd2000 deleted the nathaniel-judd/byu-team/animations branch March 1, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-hart jacob-hart jacob-hart requested changes

@gideontonkinson gideontonkinson Awaiting requested review from gideontonkinson

@agardn87 agardn87 Awaiting requested review from agardn87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Judd2000 @jacob-hart