Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'main' field for compatibility with Jest 26.x #259

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

paulkenney
Copy link
Collaborator

Description

Added 'main' field to package.json since Jest 26.x doesn't understand how to use 'module', 'browser', or 'exports' fields when this is a dependency of another package being tested.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

… how to use 'module', 'browser', or 'exports' fields when this is a dependency of another package being tested.
@paulkenney paulkenney self-assigned this Apr 22, 2024
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

@marshallpete marshallpete merged commit 9881a14 into main Apr 22, 2024
5 checks passed
@marshallpete marshallpete deleted the paulkenney/jest-26-compatibility branch April 22, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants