build: enhancements for parcel #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-275 |
marshallpete
commented
May 1, 2024
Comment on lines
+9
to
+18
| ".": { | ||
| "import": "./dist/index.js", | ||
| "types": "./dist/@types/index.d.ts", | ||
| "default": "./dist/index.js" | ||
| }, | ||
| "./alpha": { | ||
| "import": "./dist/alpha.js", | ||
| "types": "./dist/@types/alpha/index.d.ts", | ||
| "default": "./dist/alpha.js" | ||
| } |
There was a problem hiding this comment.
Parcel needs these so that it can find the right type files.
marshallpete
commented
May 1, 2024
Comment on lines
-5
to
13
| "module": "ESNext", | ||
| "module": "node16", | ||
| "target": "ES2017", | ||
| "jsx": "react-jsx", | ||
| "lib": ["ESNext", "ES5", "ES6", "DOM", "DOM.Iterable"], | ||
| "sourceMap": true, | ||
| "strict": true, | ||
| "allowJs": false, | ||
| "moduleResolution": "node", | ||
| "moduleResolution": "node16", | ||
| "forceConsistentCasingInFileNames": true, |
There was a problem hiding this comment.
ts documentation highly recommends that libraries use node16 or nodenext. This does not mean that our library has to use v16 of node.
c-lamoureux
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
typeVersions are used to get the correct types using most bundlers. These don't seem to work with Parcel so we also include export subpaths with conditional exports which do work with parcel.
We need both.