Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: trendline annotations should not be interactive #295

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: trendline annotations should not be interactive #295

merged 1 commit into from
May 8, 2024

Conversation

marshallpete
Copy link
Member

Description

Trendline annotations should not be interactive. This means that hovering them should not interrupt tooltips. This fixes that.

Screen.Recording.2024-05-08.at.1.42.34.PM.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-295

@marshallpete marshallpete merged commit 9acb64a into main May 8, 2024
5 checks passed
@marshallpete marshallpete deleted the inactiveAnnotations branch May 8, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abigail-Larsen Abigail-Larsen Abigail-Larsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marshallpete @Abigail-Larsen