Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing peer dependencies (mostly on react and react-dom) #2188

Closed
mischnic opened this issue Aug 1, 2021 · 0 comments · Fixed by #2201
Closed

Missing peer dependencies (mostly on react and react-dom) #2188

mischnic opened this issue Aug 1, 2021 · 0 comments · Fixed by #2201

Comments

@mischnic
Copy link
Contributor

mischnic commented Aug 1, 2021 •
edited

🐛 Bug Report

Yarn 2 reports various peer dependency warnings that cannot be resolved by package consumers. Most of them are caused by packages not "forwarding" peer dependencies (to react and react-dom).

😯 Current Behavior

➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pbf8f9), requested by @react-aria/ssr
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pdddd9), requested by @react-aria/i18n
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p770c6), requested by @react-stately/collections
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p35c28), requested by @react-spectrum/button
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p07852), requested by @react-spectrum/form
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pfb346), requested by @react-spectrum/menu
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p9bf2c), requested by @react-spectrum/text
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p57ff6), requested by @react-spectrum/tooltip
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p74757), requested by @react-aria/visually-hidden
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p5eb69), requested by @react-spectrum/listbox
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pd95bf), requested by @react-spectrum/overlays
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p628e0), requested by @react-spectrum/progress
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pad7be), requested by @react-spectrum/textfield
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pafda4), requested by @react-spectrum/buttongroup
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p0a1a4), requested by @react-spectrum/divider
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pc8eed), requested by @react-spectrum/layout
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p0fb74), requested by @react-spectrum/view
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p1367b), requested by @react-spectrum/checkbox
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pc39e9), requested by @react-spectrum/picker
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pfbec8), requested by @react-spectrum/actiongroup
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p8b38b), requested by @react-spectrum/breadcrumbs
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pf25ef), requested by @react-spectrum/combobox
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p8bd72), requested by @react-spectrum/dialog
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p6567a), requested by @react-spectrum/icon
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p99605), requested by @react-spectrum/illustratedmessage
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p2c899), requested by @react-spectrum/image
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pfeb81), requested by @react-spectrum/link
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p42d1c), requested by @react-spectrum/meter
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p16a8f), requested by @react-spectrum/numberfield
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pe15a1), requested by @react-spectrum/provider
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p8eb49), requested by @react-spectrum/radio
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p7ab8a), requested by @react-spectrum/searchfield
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p5465b), requested by @react-spectrum/slider
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p2d191), requested by @react-spectrum/statuslight
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pc5671), requested by @react-spectrum/switch
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pe29af), requested by @react-spectrum/tabs
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (pbd75c), requested by @react-spectrum/well
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react (p3aef2), requested by @react-stately/data
➤ YN0002: │ @adobe/react-spectrum@npm:3.12.0 doesn't provide react-dom (pf1045), requested by @react-spectrum/overlays
➤ YN0002: │ @react-aria/combobox@npm:3.0.0 [ae6b3] doesn't provide react-dom (pd9e6f), requested by @react-aria/overlays
➤ YN0002: │ @react-aria/combobox@npm:3.0.0 [ae6b3] doesn't provide react-dom (p7cc36), requested by @react-aria/live-announcer
➤ YN0002: │ @react-aria/combobox@npm:3.0.0 [ae6b3] doesn't provide react-dom (p33c68), requested by @react-aria/menu
➤ YN0002: │ @react-aria/numberfield@npm:3.0.0 [a8471] doesn't provide react-dom (p3546c), requested by @react-aria/live-announcer
➤ YN0002: │ @react-aria/select@npm:3.4.0 [827af] doesn't provide react-dom (pb49e6), requested by @react-aria/menu
➤ YN0002: │ @react-aria/spinbutton@npm:3.0.0 [bba57] doesn't provide react-dom (p27acd), requested by @react-aria/live-announcer
➤ YN0002: │ @react-spectrum/combobox@npm:3.0.0 [d73ad] doesn't provide react-dom (p38822), requested by @react-aria/overlays
➤ YN0002: │ @react-spectrum/combobox@npm:3.0.0 [d73ad] doesn't provide react-dom (p64e8c), requested by @react-spectrum/overlays
➤ YN0002: │ @react-spectrum/dialog@npm:3.3.2 [d73ad] doesn't provide react-dom (pcca0f), requested by @react-aria/overlays
➤ YN0002: │ @react-spectrum/dialog@npm:3.3.2 [d73ad] doesn't provide react-dom (p92ee5), requested by @react-spectrum/overlays
➤ YN0002: │ @react-spectrum/listbox@npm:3.5.0 [d73ad] doesn't provide react-dom (p4e90b), requested by @react-aria/virtualizer
➤ YN0002: │ @react-spectrum/menu@npm:3.3.0 [d73ad] doesn't provide react-dom (pb6a6a), requested by @react-aria/overlays
➤ YN0002: │ @react-spectrum/menu@npm:3.3.0 [d73ad] doesn't provide react-dom (p1224a), requested by @react-aria/menu
➤ YN0002: │ @react-spectrum/menu@npm:3.3.0 [d73ad] doesn't provide react-dom (pec118), requested by @react-spectrum/overlays
➤ YN0002: │ @react-spectrum/menu@npm:3.3.0 [d73ad] doesn't provide react-dom (p2fd87), requested by @react-aria/virtualizer
➤ YN0002: │ @react-spectrum/picker@npm:3.3.0 [d73ad] doesn't provide react-dom (p6fa19), requested by @react-aria/overlays
➤ YN0002: │ @react-spectrum/picker@npm:3.3.0 [d73ad] doesn't provide react-dom (p18e2d), requested by @react-spectrum/overlays
➤ YN0002: │ @react-spectrum/provider@npm:3.2.1 [d73ad] doesn't provide react-dom (p929c7), requested by @react-aria/overlays
➤ YN0002: │ @react-spectrum/theme-dark@npm:3.2.1 doesn't provide react (p5662f), requested by @react-types/provider
➤ YN0002: │ @react-spectrum/theme-default@npm:3.2.1 doesn't provide react (pe2964), requested by @react-types/provider
➤ YN0002: │ @react-spectrum/theme-light@npm:3.1.1 doesn't provide react (p6de81), requested by @react-types/provider
➤ YN0002: │ @react-spectrum/tooltip@npm:3.1.3 [d73ad] doesn't provide react-dom (p5cd76), requested by @react-aria/overlays
➤ YN0002: │ @react-spectrum/tooltip@npm:3.1.3 [d73ad] doesn't provide react-dom (p4b018), requested by @react-spectrum/overlays
➤ YN0002: │ @react-spectrum/tooltip@npm:3.1.3 [d73ad] doesn't provide react-dom (pddcf5), requested by @react-aria/tooltip
➤ YN0002: │ @spectrum-icons/ui@npm:3.2.0 [2732a] doesn't provide @react-spectrum/provider (pbb15f), requested by @react-spectrum/icon
➤ YN0002: │ @spectrum-icons/ui@npm:3.2.0 [2732a] doesn't provide react-dom (p6ab09), requested by @adobe/react-spectrum-ui
➤ YN0002: │ @spectrum-icons/workflow@npm:3.2.0 [2732a] doesn't provide @react-spectrum/provider (pc45f1), requested by @react-spectrum/icon
➤ YN0002: │ @spectrum-icons/workflow@npm:3.2.0 [2732a] doesn't provide react-dom (p87441), requested by @adobe/react-spectrum-workflow

💁 Possible Solution

Declare these as peer dependencies

🔦 Context

https://yarnpkg.com/advanced/error-codes#yn0002---missing_peer_dependency

💻 Code Sample

{
  "dependencies": {
    "@adobe/react-spectrum": "^3.12.0",
    "react": "^17.0.2",
    "react-dom": "^17.0.2"
  }
}
  1. Create package.json from above
  2. yarn set version berry
  3. yarn

🌍 Your Environment

Software Version(s)
react-spectrum "@adobe/react-spectrum": "^3.12.0",
Yarn 3.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing peer dependencies adobe/react-spectrum
1 participant
@mischnic