Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected checkbox in a disabled checkbox group has the wrong fill color #5378

Closed
LFDanLu opened this issue Nov 7, 2023 · 0 comments · Fixed by #5407
Closed

Selected checkbox in a disabled checkbox group has the wrong fill color #5378

LFDanLu opened this issue Nov 7, 2023 · 0 comments · Fixed by #5407
Labels
bug Something isn't working

Comments

@LFDanLu
Copy link
Member

LFDanLu commented Nov 7, 2023

Provide a general summary of the issue here

The fill color for a selected checkbox in a disabled checkbox group has the wrong fill color, see below.

🤔 Expected Behavior?

image

😯 Current Behavior

Current:
image

💁 Possible Solution

The css for

.spectrum-Checkbox-input,
.spectrum-Checkbox-input:checked {
&:disabled + .spectrum-Checkbox-box,
&:disabled:active + .spectrum-Checkbox-box {
&:before {
border-color: var(--spectrum-checkbox-emphasized-box-border-color-disabled);
background-color: var(--spectrum-checkbox-emphasized-box-background-color-disabled);
}
}
should win over
&.spectrum-Checkbox--quiet {
.spectrum-Checkbox-input:checked + .spectrum-Checkbox-box,
&.is-indeterminate .spectrum-Checkbox-box,
&.is-indeterminate .spectrum-Checkbox-input:focus-visible + .spectrum-Checkbox-box {
&:before {
border-color: var(--spectrum-checkbox-quiet-box-border-color-selected);
}
}

🔦 Context

No response

🖥️ Steps to Reproduce

See https://reactspectrum.blob.core.windows.net/reactspectrum/6c61f5b1db5f52ebc654bf754a15594bb0662f6f/storybook/index.html?path=/story/checkboxgroup--controlled-value&args=isDisabled:true&providerSwitcher-express=false

Version

3.31

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

If other, please specify.

No response

What operating system are you using?

MacOS 14.1

🧢 Your Company/Team

Adobe Admin Experience

🕷 Tracking Issue

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant